-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specialized instrumentation for different cases #109
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # ulyp-benchmarks/build.gradle # ulyp-common/src/main/java/com/ulyp/core/recorders/collections/MapRecorder.java
# Conflicts: # ulyp-agent-core/src/main/java/com/ulyp/agent/AgentContext.java # ulyp-agent-core/src/main/java/com/ulyp/agent/Recorder.java # ulyp-agent-core/src/test/java/com/ulyp/agent/RecorderTest.java # ulyp-agent-tests/src/test/java/com/agent/tests/recorders/RecursiveArrayRecorderTest.java # ulyp-common/src/main/java/com/ulyp/core/mem/RecordedMethodCallList.java # ulyp-common/src/main/java/com/ulyp/core/util/BitUtil.java # ulyp-common/src/test/java/com/ulyp/core/mem/RecordedMethodCallListTest.java # ulyp-common/src/test/java/com/ulyp/core/recorders/bytes/BinaryInputOutputTest.java
# Conflicts: # ulyp-common/src/main/java/com/ulyp/core/recorders/bytes/BinaryOutput.java # ulyp-common/src/main/java/com/ulyp/core/recorders/bytes/BufferBinaryOutput.java # ulyp-common/src/main/java/com/ulyp/core/util/Constants.java # ulyp-common/src/main/java/com/ulyp/core/util/ObjectPool.java # ulyp-common/src/main/java/com/ulyp/core/util/PaddedAtomicIntegerArray.java
# Conflicts: # ulyp-common/src/main/java/com/ulyp/core/mem/ManagedMemPool.java # ulyp-common/src/main/java/com/ulyp/core/mem/MemRegion.java # ulyp-common/src/main/java/com/ulyp/core/mem/Page.java # ulyp-common/src/main/java/com/ulyp/core/recorders/bytes/BinaryOutput.java # ulyp-common/src/main/java/com/ulyp/core/recorders/bytes/PagedMemBinaryOutput.java
# Conflicts: # ulyp-benchmarks/build.gradle # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/instrumentation/InstrumentationBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/instrumentation/InstrumentedMethodBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/ActiveMQBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/ActiveMQBootstrapBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/H2Benchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/H2BootstrapBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/HazelcastBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/HazelcastBootstrapBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/SpringHibernateBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/libs/SpringHibernateBootstrapBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/recording/CollectionRecordingBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/recording/FibonacciNumbersBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/recording/NumbersRecordingBenchmark.java # ulyp-benchmarks/src/jmh/java/com/perf/agent/benchmarks/util/BenchmarkConstants.java # ulyp-common/src/main/java/com/ulyp/core/bytes/AbstractBinaryOutput.java
# Conflicts: # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/RecordingEventProcessor.java
# Conflicts: # ulyp-agent-core/src/main/java/com/ulyp/agent/AgentContext.java # ulyp-agent-core/src/main/java/com/ulyp/agent/Recorder.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/CachedDirectBufMemPageAllocator.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/DirectBufMemPageAllocator.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/QueueBatchEventProcessor.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/QueueBatchEventProcessorFactory.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/RecordingEventProcessor.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/RecordingQueue.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/disruptor/EventHandlerGroup.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/disruptor/RecordingQueueDisruptor.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/disruptor/RingBuffer.java # ulyp-agent-core/src/main/java/com/ulyp/agent/queue/disruptor/WorkProcessor.java # ulyp-agent-core/src/test/java/com/ulyp/agent/RecorderCurrentSessionCountTest.java # ulyp-agent-core/src/test/java/com/ulyp/agent/RecorderTest.java # ulyp-agent/src/main/java/com/ulyp/agent/Agent.java # ulyp-benchmarks/build.gradle # ulyp-common/src/main/java/com/ulyp/core/CallRecordBuffer.java # ulyp-common/src/main/java/com/ulyp/core/mem/InputBinaryList.java # ulyp-common/src/main/java/com/ulyp/core/mem/MemPage.java # ulyp-common/src/main/java/com/ulyp/core/mem/OutputBinaryList.java # ulyp-common/src/main/java/com/ulyp/core/mem/PageConstants.java # ulyp-common/src/main/java/com/ulyp/core/mem/RecordedMethodCallList.java # ulyp-common/src/main/java/com/ulyp/core/serializers/RecordedEnterMethodCallSerializer.java # ulyp-common/src/main/java/com/ulyp/core/util/Constants.java # ulyp-common/src/main/java/com/ulyp/core/util/SmallObjectPool.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@@ -128,6 +128,9 @@ public void enqueueMethodExit(int recordingId, int callId, Object returnValue, b | |||
} | |||
|
|||
private Object[] convert(Object[] args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, we can not. Unlike Rust/C++, Java Optional
is not zero-cost. In Ulyp we strive for maximum performance for our clients' recorded applications even at the cost of readability.
# Conflicts: # ulyp-agent-core/src/main/java/com/ulyp/agent/AgentDataWriter.java # ulyp-common/src/main/java/com/ulyp/core/mem/SerializedRecordedMethodCallList.java # ulyp-common/src/main/java/com/ulyp/core/serializers/RecordedEnterMethodCallSerializer.java
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.