New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeERC404 - fix transfer indexing issue and enforce ERC-721 transfers #11

Closed

ghost wants to merge 1 commit into 0xacme:main from zerotwodao:safe-erc404

ghost commented Feb 11, 2024

Enforce safeTransferFrom for ERC-721 transfers in order to prevent ERC-20 supportive contracts going rekt due to unwanted amount transfers
Fix event indexing issue, most of the ERC-404 tokens right now couldn't display transfer events correctly and thus doesn't shown as a token

Live code: https://bscscan.com/token/0x4EaaFE15Fb4aC7B1BD9428f2dc3f7E54Fb689E7b#code

You can see the transfer events being correctly indexed here

https://bscscan.com/token/0x4EaaFE15Fb4aC7B1BD9428f2dc3f7E54Fb689E7b


          SafeERC404

4f62f22

ghost mentioned this pull request

ERC-20 transfer events not being handled correctly #12

Open

ghost closed this by deleting the head repository

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment