Only prepend /usr/local/bin to $PATH if its not already there. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As many commons scripts already add it to path, we do not want to overwrite these. For example brew or conda might have preferences for this not being the first entry, but might already add it. So do not overwrite the path with such a destructive choice if we can already find /usr/local/bin in Path
0xacx
reviewed
Mar 27, 2023
|
@emirkmo Thank you for this PR! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During install, only prepend /usr/local/bin to $PATH if its not already in the $PATH.
Problem:
As many commons scripts already add /usr/local/bin it to path, we do not want to overwrite these, especially since it may cause PATH conflicts.
For example brew or conda might have preferences for this not being the first entry, but might already add it. So do not overwrite the path with such a destructive choice if we can already find /usr/local/bin in Path. Only add it if we do not find it.