Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation improvments: Add .zshrc to install script, avoid overwriting $PATH if /usr/local/bin already found #65

Closed
emirkmo opened this issue Mar 27, 2023 · 2 comments

Comments

@emirkmo
Copy link
Contributor

emirkmo commented Mar 27, 2023

I made two PRs to solve issues I ran into while installing on my machine. Basically, the install script does not check for .zshrc, which is actually the place to put anything related to interactive sessions, such as this package. I do not have a .zprofile on m debian machine, and this is common.

I also did not want /usr/local/bin prepended to my path. It is already therem but is located after conda / mambaforge bin for virtual environment purposes, which is the standard conda install. So the install script should not prepend it.

I made two PRs that solve the issues. #63 and #64

Hope they are useful. Let me know if you have any questions.

@Zeioth
Copy link

Zeioth commented Mar 28, 2023

What distro are you on? install.sh work, but it is more like a reference script. Ideally we should have a package per distro, like the one we already have for arch. A pip package to install it easily is also WIP right now.

In those, .profile and path won't be modified.

@0xacx
Copy link
Owner

0xacx commented Apr 8, 2023

Both PRs are addressed so this issue is done! 👍

@0xacx 0xacx closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants