Add unit test for broken signature function

Skip URLs when signature unscrambling fails in order to get proper restricted playback error (XCDYouTubeErrorRestrictedPlayback) instead of media player playback error caused by an invalid stream URL (missing signature).
0xced · Jul 17, 2014 · c9e9e0b · c9e9e0b
1 parent 869b722
commit c9e9e0b
Show file tree

Hide file tree

Showing 3 changed files with 95 additions and 0 deletions.
diff --git a/...ttes/XCDYouTubeProtectedVideosTestCase/testProtectedVideoWithBrokenSignatureFunction.json b/...ttes/XCDYouTubeProtectedVideosTestCase/testProtectedVideoWithBrokenSignatureFunction.json
diff --git a/XCDYouTubeKit Tests/XCDYouTubeProtectedVideosTestCase.m b/XCDYouTubeKit Tests/XCDYouTubeProtectedVideosTestCase.m
@@ -132,6 +132,20 @@ - (void) testProtectedVideoWithoutSignatureFunction
 	XCTAssertTrue([monitor waitWithTimeout:10]);
 }
 
+// Edit testProtectedVideoWithBrokenSignatureFunction.json by returning null in the signature function
+- (void) testProtectedVideoWithBrokenSignatureFunction
+{
+	TRVSMonitor *monitor = [TRVSMonitor monitor];
+	[[XCDYouTubeClient defaultClient] getVideoWithIdentifier:@"Pgum6OT_VH8" completionHandler:^(XCDYouTubeVideo *video, NSError *error) {
+		XCTAssertNil(video);
+		XCTAssertEqualObjects(error.domain, XCDYouTubeVideoErrorDomain);
+		XCTAssertEqual(error.code, XCDYouTubeErrorRestrictedPlayback);
+		XCTAssertEqualObjects(error.localizedDescription, @"This video contains content from WMG. It is restricted from playback on certain sites. Watch on YouTube");
+		[monitor signal];
+	}];
+	XCTAssertTrue([monitor waitWithTimeout:10]);
+}
+
 // Edit testProtectedVideoWithoutJavaScriptPlayerURL.json by replacing `\"js\":` with `\"xs\":`
 - (void) testProtectedVideoWithoutJavaScriptPlayerURL
 {

diff --git a/XCDYouTubeKit/XCDYouTubeVideo.m b/XCDYouTubeKit/XCDYouTubeVideo.m
@@ -105,6 +105,8 @@ - (instancetype) initWithIdentifier:(NSString *)identifier info:(NSDictionary *)
 
 			NSString *scrambledSignature = stream[@"s"];
 			NSString *signature = [playerScript unscrambleSignature:scrambledSignature];
+			if (playerScript && !signature)
+				continue;
 
 			NSString *urlString = stream[@"url"];
 			NSString *itag = stream[@"itag"];