Exclude plist files from SPM #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreiVidrasco Thanks for the contribution. I remember trying to this before but it still gave me that error. 0054d0d Can you confirm with this change you are no longer getting errors? |
|
I checked by running simple |
SoneeJohn
approved these changes
Apr 27, 2020
SoneeJohn
added a commit
that referenced
this pull request
Apr 27, 2020
* Deprecated `-[XCDYouTubeVideo thumbnailURL]` use `-[XCDYouTubeVideo thumbnailURLs]` (#477) * Exclude plist files from Swift Package Manager (#478) * Annotate `languageIdentifier` argument as `nullable` in `XCDYouTubeVideoOperation` * Add new `author`, `videoDescription` and `channelIdentifier` properties to `XCDYouTubeVideo` (#471)
Hesowcharov
pushed a commit
to Hesowcharov/XCDYouTubeKit
that referenced
this pull request
Sep 27, 2023
* Deprecated `-[XCDYouTubeVideo thumbnailURL]` use `-[XCDYouTubeVideo thumbnailURLs]` (0xced#477) * Exclude plist files from Swift Package Manager (0xced#478) * Annotate `languageIdentifier` argument as `nullable` in `XCDYouTubeVideoOperation` * Add new `author`, `videoDescription` and `channelIdentifier` properties to `XCDYouTubeVideo` (0xced#471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment when building the library via SPM, it produces 3 warnings because plist files are added in the project as compilable files.
This PR excludes them from SPM
About warning: https://stackoverflow.com/questions/6509600/compilation-warning-no-rule-to-process-file-for-architecture-i386
Screenshot:
