Gameover bugfix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this fixes Issue #1; I was mistakenly updating the highest_occupied_cell twice, once correctly in clear_rows() and then once in the wrong direction in update_score(). Since it was updated twice, it would never move down when rows were cleared - resulting in the highest cell only climbing during gameplay, eventually reaching the gameover condition. #1
0xjmux
added a commit
that referenced
this pull request
Mar 23, 2024
* Fixed tg_update_score so it changes lines_cleared_last_level in right direction * debugging prints peppered through problem code areas * clear_rows modified so it won't try to move rows above the top of the board down, which is a possible cause of the premature crash as a result of garbage data I've been seeing (Issue #2). Garbage data ends up in the first few rows, pieces can't move down into it, they stop falling, and then the game_over condition activates. * to fix this, added another loop to clear_rows() so that it stops once it would start touching the top of the board, and will fill rows at the top with BG_COLOR without trying to read OOB * lines_cleared_since_last_level static var that was a part of tg_update_score moved to TetrisGame struct for easier monitoring and testing; moving it makes replicating crash conditions in unit test suites much easier. * print_board_state() function updated to take `bool ini_out` argument, which prepends boards printed to .ini files with the `;` comment character * several new unit test cases added to `suite_1.c`, mostly for clear_rows() and relating functions. * a couple new savegame .ini files added; some of these will likely be removed in the future, but they're very useful for replicating specific board conditions for testing. * ini saving functionality moved to utils.c so it's all aggregated in the same place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #1