Update Slither and fix warnings

.github/workflows/analyze.yml

@@ -14,13 +14,9 @@ jobs:
         with:
           version: nightly
 
-      - name: Compile contracts
-        run: forge build --force
-
       - name: Run Slither
-        uses: crytic/slither-action@v0.1.1
+        uses: crytic/slither-action@v0.2.0
         with:
-          ignore-compile: true
           node-version: 16
           slither-config: ./slither.config.json
-          slither-version: v0.8.3
+          slither-version: v0.9.2

foundry.toml

@@ -1,5 +1,5 @@
 [profile.default]
-solc = '0.8.19'
+solc = '0.8.16'
 bytecode_hash = 'none'
 optimizer_runs = 1000000
 

slither.config.json

@@ -2,6 +2,5 @@
 	"detectors_to_run": "all",
 	"exclude_informational": true,
 	"exclude_low": true,
-	"filter_paths": "(lib/)",
-	"ignore_compile": true
+	"filter_paths": "(lib/|test/)"
 }

src/SampleContract.sol

@@ -1,25 +1,29 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.19;
+pragma solidity 0.8.16;
 
 contract SampleContract {
     uint256 num2;
 
     function func1(uint256 num) external {
         num2 = num;
 
+        // slither-disable-start costly-loop
         for (uint256 i = 0; i < num; i++) {
             num2--;
         }
+        // slither-disable-end costly-loop
 
         assert(num2 == 0);
     }
 
     function func2(uint256 num) external {
         num2 = num;
 
+        // slither-disable-start costly-loop
         for (uint256 i = 0; i < num; i++) {
             num2--;
         }
+        // slither-disable-end costly-loop
 
         assert(num2 == 0);
     }

test/SampleContract.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.19;
+pragma solidity 0.8.16;
 
 import {Test} from 'forge-std/Test.sol';
 

test/echidna/EchidnaUtils.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.19;
+pragma solidity ^0.8.16;
 
 library EchidnaUtils {
     event AssertionFailed(string msg, uint256 expected, uint256 actualValue);

test/echidna/PairEchidna.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.19;
+pragma solidity ^0.8.16;
 
 import "./EchidnaUtils.sol";