Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u32 assembly parsers for shift/rotate ops fail with legal parameter value 0 #76

Closed
grjte opened this issue Jan 25, 2022 · 1 comment
Closed

u32 assembly parsers for shift/rotate ops fail with legal parameter value 0 #76

grjte opened this issue Jan 25, 2022 · 1 comment
Labels
assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers

Comments

@grjte
Copy link
Collaborator

grjte commented Jan 25, 2022

The shift and and rotation operations in the assembly parsers are enforcing parameter bounds on the bit shift value of 1 <= b <= 31, but according to the assembly specs parameter value b = 0 should be allowed.

This should be fixed in parse_u32shl, parse_u32shr, parse_u32rotl, parse_u32rotr in the Assembly ops parsers.
@grjte grjte mentioned this issue Jan 25, 2022
Merged
@bobbinth bobbinth added assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers labels Jan 25, 2022
@willyrgf willyrgf mentioned this issue Feb 2, 2022
Merged
@bobbinth
Copy link
Contributor

bobbinth commented Feb 2, 2022

Fixed by #92

@bobbinth bobbinth closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assembly Related to Miden assembly bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobbinth @grjte