Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update u32 ops proptests in the processor to only test valid cases #79

Closed
grjte opened this issue Jan 25, 2022 · 1 comment
Closed

Update u32 ops proptests in the processor to only test valid cases #79

grjte opened this issue Jan 25, 2022 · 1 comment
Assignees
@grjte
Labels
processor Related to Miden VM processor tests Related to tests

Comments

@grjte
Copy link
Collaborator

grjte commented Jan 25, 2022 •
edited

Given that proptest may need different sampling for valid vs. invalid inputs, it makes sense to handle these separately.

As discussed, we've decided to handle error cases in manual tests and only test validity in the randomized tests.

This should be updated in the processor u32 tests here

Maybe invalid cases can be handled in manual tests? And the test validity of operations over valid inputs using randomized tests?

Originally posted by @bobbinth in #75 (comment)
@bobbinth bobbinth added tests Related to tests processor Related to Miden VM processor labels Jan 26, 2022
grjte added a commit to grjte/miden that referenced this issue Jan 31, 2022
@grjte
test: remove failure cases from proptests
e45c7c9 
This addresses issue 0xPolygonMiden#79 to use proptests only for validity testing and handle error cases in manual tests
@grjte grjte mentioned this issue Jan 31, 2022
Merged
@bobbinth
Copy link
Contributor

Fixed by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grjte grjte

Labels
processor Related to Miden VM processor tests Related to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobbinth @grjte