Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

HttpClient.getFeesAsync mutates params #274

Closed
nightwolfz opened this issue Dec 19, 2017 · 2 comments
Closed

HttpClient.getFeesAsync mutates params #274

nightwolfz opened this issue Dec 19, 2017 · 2 comments
Assignees
Labels

Comments

@nightwolfz
Copy link

nightwolfz commented Dec 19, 2017

Example

Object.assign(feesRequest, {
  makerTokenAmount: new BigNumber(makerTokenAmount), // units offered
  takerTokenAmount: new BigNumber(takerTokenAmount), // units requested
})
console.log(typeof feesRequest.makerTokenAmount) // BigNumber

const feesResponse = await relayerClient.getFeesAsync(feesRequest)

console.log(typeof feesRequest.makerTokenAmount) // string
@fabioberger
Copy link
Contributor

Yep, that's a bug, thanks for the heads up! Will fix.

@BMillman19
Copy link
Contributor

Addressed in #296

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants