This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Prevent getFeesAsync method on HttpClient from mutating input #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
approved these changes
Dec 25, 2017
| const takerTokenAmountBefore = new BigNumber(request.takerTokenAmount); | ||
| const saltBefore = new BigNumber(request.salt); | ||
| const expirationUnixTimestampSecBefore = new BigNumber(request.expirationUnixTimestampSec); | ||
| await relayerClient.getFeesAsync(request); |
There was a problem hiding this comment.
Are we sure there is no mutation in any of the other methods in Connect?
|
@BMillman19 don't forget to add a CHANGELOG entry for |
* development: Changes to abi-gen after code review Added constructor ABIs to abi-gen Describe #295 in a CHANGELOG Add #302 description to changelog Fix formatting Apply prettier config Install prettier Remove formatting esilnt rules sendTransactionAsync should return txHash string Added Event generation to abi-gen Publish Add dates to CHANGELOG entries Update subproviders CHANGELOG Support both personal_sign and eth_sign Fix Ledger tests given change from `personal_sign` to `eth_sign` Update subprovider to catch correct RPC method Rename guide Update contribution guide Fix broken links in the abi-gen README Fix typing generation for arrays in which types separated by |s
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
feesRequestingetFeesAsync()_reqestAsync()method already takes care of this for us