Fix arch name in rootfs builder #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rootfs builder was using `adjust_arch` where the x86_64 architecture is named `x86-64`, which does not work for the rootfs.sh script (it is expecting `x86_64`).
|
Good catch! That's a confirmed bug. Another strong case for going ahead and implementing #39 ASAP to catch these (refactoring) errors early.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rootfs builder was using
adjust_archwhere the x86_64 architecture isnamed
x86-64, which does not work for therootfs.shscript (it isexpecting
x86_64).