Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callContract() #6

Closed
1 of 2 tasks
0xs34n opened this issue Oct 19, 2021 · 7 comments · Fixed by #23
Closed
1 of 2 tasks

callContract() #6

0xs34n opened this issue Oct 19, 2021 · 7 comments · Fixed by #23
Labels
good first issue Good for newcomers released on @next released Type: feature New feature or request

Comments

@0xs34n
Copy link
Collaborator

0xs34n commented Oct 19, 2021 •
edited by janek26
Loading

  • Test in __tests__
  • Generate a valid invokeTx
@janek26
Copy link
Member

janek26 commented Oct 20, 2021

Blocked by #7 afaik

@0xs34n
Copy link
Collaborator Author

0xs34n commented Oct 20, 2021 •
edited
Loading

How is it blocked by #7 ?

This is how the CLI calls callContract():

starknet call \
    --address CONTRACT_ADDRESS \
    --abi contract_abi.json \
    --function get_balance

@janek26
Copy link
Member

janek26 commented Oct 20, 2021

Ah sorry! Add transaction is blocked, right?

@0xs34n
Copy link
Collaborator Author

0xs34n commented Oct 20, 2021 •
edited
Loading

Don't believe so (correct me if I'm wrong)

addTransaction() is equivalent to invoke in CLI and is ran like following:

starknet invoke \
    --address CONTRACT_ADDRESS \
    --abi contract_abi.json \
    --function increase_balance \
    --inputs 1234

I think the signature will be provided in the --inputs but it is not required

@janek26
Copy link
Member

janek26 commented Oct 20, 2021

Ah, I know why. Nothing blocked, sorry

@janek26 janek26 added Type: feature New feature or request good first issue Good for newcomers labels Oct 23, 2021
@janek26 janek26 linked a pull request Oct 25, 2021 that will close this issue
feat: enable invokeFunction transactions #23
Merged
github-actions bot pushed a commit that referenced this issue Oct 27, 2021
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
de1afcb 
# [1.2.0](v1.1.1...v1.2.0) (2021-10-27)

### Bug Fixes

* commitlint for release ([e8ad972](e8ad972))
* **docs:** new docs page ([2e46cff](2e46cff))
* remove useless comment ([ebf07b4](ebf07b4))

### Features

* implement needed helper methods ([46f7173](46f7173))
* introduce contract class ([db322fd](db322fd))
* type and use callContract ([10c7fc4](10c7fc4)), closes [#6](#6)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xs34n 0xs34n closed this as completed in 10c7fc4 Oct 27, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers released on @next released Type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable invokeFunction transactions starknet-io/starknet.js
2 participants
@janek26 @0xs34n