feat: add starknet.id getters

[fricoben]

close #382

I needed to use some of our code as utils (because of our encoding algorithm), so I created my own utils file (these functions will only be used for starknet id so it makes sense to create our own file).

I tried to be as clean as possible and everything works smoothly. Tell me what you think.

[netlify]

✅ Deploy Preview for starknetjs canceled.

Name	Link
🔨 Latest commit	81f5d71
🔍 Latest deploy log	https://app.netlify.com/sites/starknetjs/deploys/6389b40e220f9000083121e1

[ivpavici]

@0xBenaparte left a couple of cosmetic comments, plus please add the changes in documentation! :)

Other than those I have nothing else, maybe someone else can comment the fact that the logic is inside the Account @tabaktoni @dhruvkelawala

[dhruvkelawala]

I don't think so starknet.id should be a part of starknet.js. I think it's a better idea to create a separate lib for all the encoding and decoding.

[ivpavici]

@janek26 @dhruvkelawala seems that Ethers.js has support for ENS
https://docs.ethers.io/v5/api/providers/provider/#Provider--ens-methods

[janek26]

I'm with Dhruv on this one. I dont think it should be part of starknet.js for now.
We dont know how/if ENS will enter Starknet etc.

In any case I would avoid to change the Provider/Account interface

[ivpavici]

What do you think about some compromise, like Ethers has a separate EnsResolver ? https://docs.ethers.io/v5/api/providers/provider/#EnsResolver

Btw I'm sorry this discussion is happening now when the work by @0xBenaparte is already done

[fricoben]

I think it would be easier for all starknet developers if it is (Loaf from Realms, @fracek, and Astraly directly asked us to do it).

If ENS enter starknet (starknet.id gonna make a bridge in the future for it) there is still no problem cause you can access them through another hook (getEnsName !== getStarkName).

To avoid confusion, I could not place it in the account class but more as a util that can be accessed through starknet.js (cause at the end of the day considering the popularity of starknet.id right now, it'll be util for a lot of devs).

Tell me what you think.

[fricoben]

Hey @janek26,

As discussed with @ivpavici I removed my changes to the account interface. Tell me if it's ok for you.

[janek26]

Yep, much happier! Thanks

[fricoben]

It is going to be used to allow the usage of non Latin characters but the alphabet extension has not yet be decided.

More info about encoding here ==> https://docs.starknet.id/for-devs/encoding-algorithm

[fricoben]

I made all the changes, tell me what you think, @janek26.

Thanks a lot !

[janek26]

looks good! one minor thing which should be done before merge

[github-actions]

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀