Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity version update #41

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Solidity version update #41

merged 7 commits into from
Mar 20, 2023

Conversation

ScreamingHawk
Copy link
Contributor

  • Update to sol ^0.8.0
  • Remove safe math
  • Fix hardhat version as version updates break tests

@ScreamingHawk
Copy link
Contributor Author

This will fail until the ERC-1155 update is merged and package updated here.

@ScreamingHawk ScreamingHawk changed the title Solidity version update WIP: Solidity version update Mar 15, 2023
@ScreamingHawk ScreamingHawk changed the title WIP: Solidity version update Solidity version update Mar 16, 2023
acrylix
acrylix approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@acrylix acrylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acrylix acrylix merged commit db4702f into master Mar 20, 2023
@acrylix acrylix deleted the sol-update branch March 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrylix acrylix acrylix approved these changes

@Agusx1211 Agusx1211 Agusx1211 approved these changes

@pkieltyka pkieltyka Awaiting requested review from pkieltyka

@PhABC PhABC Awaiting requested review from PhABC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ScreamingHawk @acrylix @Agusx1211