Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added auto hide feature in hls controls #1382

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

stanwolverine
Copy link
Member

Description

Controls auto hide after 3sec delay and are shown on tap

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I have updated the ExampleAppChangelog.txt file with relevant changes.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stanwolverine stanwolverine requested a review from ygit April 16, 2024 11:24
@stanwolverine stanwolverine self-assigned this Apr 16, 2024
Copy link

trunk-io bot commented Apr 16, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

stanwolverine and others added 3 commits April 17, 2024 12:35
Increased timeout seconds before view is hidden

Co-authored-by: ygit <ygit@users.noreply.github.com>
…s.tsx

Co-authored-by: ygit <ygit@users.noreply.github.com>
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 98fd24f into develop Apr 17, 2024
4 checks passed
@ygit ygit deleted the hls-player-auto-hide-controls branch April 17, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants