Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN-308: Added whiteboard UI in prebuilt #1391

Merged
merged 26 commits into from
May 14, 2024
Merged

RN-308: Added whiteboard UI in prebuilt #1391

merged 26 commits into from
May 14, 2024

Conversation

stanwolverine
Copy link
Member

also closes RN-309

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I have updated the ExampleAppChangelog.txt file with relevant changes.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stanwolverine stanwolverine requested a review from ygit May 2, 2024 14:43
@stanwolverine stanwolverine self-assigned this May 2, 2024
@trunk-io Trunk.io
Copy link

trunk-io bot commented May 2, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@stanwolverine stanwolverine marked this pull request as ready for review May 3, 2024 12:46
ygit and others added 15 commits May 3, 2024 18:56
@ygit
released sample app version 2.4.23 (473) ⚛️
e97e72e
@stanwolverine
fix(prebuilt): 🐛 tile content cutting off from bottom in webrtc layout
728a3ae 
when controls are visible
@ygit
updated Example app changelog
88b6275
@ygit
released sample app version 2.4.25 (475) ⚛️
c298888
@stanwolverine
fix(prebuilt): 🐛 webview tapping issue with react native gesture handler
4a5d0e9 
android: when webview is wrapped in gesture handler, touches on some elements of whiteboard does not work
@stanwolverine
fix(prebuilt): 🐛 header and footer overlapping whiteboard
9557c7e 
android: hiding header and footer when user switches to landscape mode when whiteboard is visible
@ygit
removed getters from whiteboard object
785fc02
@stanwolverine
Merge branch 'RN-306' into RN-308
80aa6bc
@stanwolverine
removed usage of whiteboard isAdmin, isOpen, isOwner properties
99869ea
@stanwolverine
disable whiteboard button when local peer is not owner
0586e23
@stanwolverine
fix: 🐛 ios: webview not reloanding after error
452b425
@stanwolverine
rn js, ios and android sdk whiteboard changes
d9ec070
@stanwolverine
Merge branch 'RN-306' into RN-308
35bb89c
@stanwolverine
using whiteboard.isOwner property
98e580a
@ygit
Merge branch 'develop' into RN-308
50727ea
ygit
ygit approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 3bc6288 into develop May 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

Assignees

@stanwolverine stanwolverine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanwolverine @ygit