Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Are the types wrong?" reveals that the ESM modules in this package are masquerading as CJS from a type perspective (https://arethetypeswrong.github.io/?p=fflate%400.8.0):
This PR fixes the situation by creating a separate declaration file per module as recommended in the TypeScript documentation:
Creating a declaration file per module fixes the type module resolution and fixes the "Are the types wrong?" tests:
The resulting built files now all specify whether they are CJS or MJS with the corresponding file extension and each module now has a corresponding declaration file which absolves the need to explicitly list them in
package.json#exports
: