Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CheckUniqueView #111

Closed
sumit4613 opened this issue Sep 12, 2021 · 1 comment
Closed

Refactor CheckUniqueView #111

sumit4613 opened this issue Sep 12, 2021 · 1 comment
Labels
enhancement good first issue Easy to fix issues invalid

Comments

@sumit4613
Copy link
Member

Describe the feature you'd like

We need to refactor CheckUniqueView.
Validation part should be written at serializer level. Move out def validated to serializer. Also, use Response from DRF to return response.

Is your feature request related to a problem?

Your Environment

  • drf-user version(s) (drf-user --version:
  • Operating System(s):
  • Python version(s):

Additional context
@sumit4613
Copy link
Member Author

Looks like this is not valid. Will be closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy to fix issues invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sumit4613