Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode 9 compile failed #14

Closed
crossle opened this issue Jun 6, 2017 · 24 comments
Closed

XCode 9 compile failed #14

crossle opened this issue Jun 6, 2017 · 24 comments
Assignees

Comments

@crossle
Copy link

crossle commented Jun 6, 2017

GzipSwift/zlib/module.modulemap:1:8: note: previously defined here
module zlib [system] {
^
:0: error: could not build Objective-C module 'Gzip'

@ramki982
Copy link

ramki982 commented Jun 6, 2017

+1 - facing the same issue

@crossle
Copy link
Author

crossle commented Jun 6, 2017

remove zib work well

@ramki982
Copy link

ramki982 commented Jun 6, 2017

yes removing it from module map seems to fix it

@HarukaMa
Copy link

HarukaMa commented Jun 6, 2017

It seems that 10.13 SDK has already included zlib in objc module map, so we won't need to manually include that module anymore.

@crossle
Copy link
Author

crossle commented Jun 7, 2017

@HarukaMa YES

@1024jp 1024jp self-assigned this Jun 7, 2017
@1024jp
Copy link
Owner

1024jp commented Jun 7, 2017

I've just pushed swift4 branch. Give it a try.

I'll keep it as a branch until a stable Xcode 9 is released.

@richardPFisk
Copy link

richardPFisk commented Jul 25, 2017

I can confirm that XCode-beta4 builds GzipSwift perfectly.
pod 'GzipSwift', :git => 'https://github.com/1024jp/GzipSwift.git', :branch => 'swift4'

Thanks for your work fixing this and your hard work creating this public code-base.

@lukegardiner
Copy link

Thanks. Solved my problems building the app with Xcode9 GM

@BrendanBuono
Copy link

Can we get the swift4 branch merged soon with the Release of XCode 9 GM?

@1024jp
Copy link
Owner

1024jp commented Sep 14, 2017

@BrendanBuono Well, I'll do it in this weekend.

@1024jp
Copy link
Owner

1024jp commented Sep 17, 2017

I've just merged the swift4 branch to master branch (develop as well).

@BrendanBuono
Copy link

Thanks! Could we get the Cocoapod updated as well please?

@ravijain412
Copy link

I tried Gzip beta and it worked on Xcode 9 but it started failing on Xcode 8. We are using GzipSwift as a dependency in our sdk. If we ship it with Xcode 9 , it will break for developers who are using Xcode 8. Any solution to this problem ?

@1024jp
Copy link
Owner

1024jp commented Sep 20, 2017

@BrendanBuono
Oups, I totally forgot about that. I'll update it when I have a time (Sorry, I'm busy recently...).

@ravijain412
Use GzipSwift 3.1.4 for Xcode 8/Swift 3.x.

@crossle
Copy link
Author

crossle commented Sep 20, 2017

How to use swift3.x version on Xcode 9?

@BrendanBuono
Copy link

No problem, @1024jp thank you!

@amayatsky
Copy link

pod 'GzipSwift', :git => 'https://github.com/1024jp/GzipSwift.git', :branch => 'master' works for a time being

@crossle
Copy link
Author

crossle commented Sep 25, 2017

Already switch to Swift4, work well

@1024jp
Copy link
Owner

1024jp commented Sep 25, 2017

Now, I've pushed GzipSwift 4.0 to CocoaPods server :)
Give it try.

@1024jp
Copy link
Owner

1024jp commented Sep 25, 2017

Note: I'll remove swift4 branch at some time point in October.

@maningyt
Copy link

@1024jp Just tried pod install, still "Installing GzipSwift(3.1.4)"

@amayatsky
Copy link

amayatsky commented Sep 26, 2017 via email

@maningyt
Copy link

@amayatsky resolved by changing podfile: pod 'GzipSwift', '~> 4.0.0’
Doesn't work without version.
Tried: pod update GzipSwift first, did updated to 4.0.0, but caused compile error because of podfile.lock. So I deleted the pod folder, and ran the new podfile. Can build now.

@1024jp 1024jp closed this as completed Nov 11, 2017
@1024jp
Copy link
Owner

1024jp commented Nov 11, 2017

I'll remove swift4 branch since the branch was merged to the master branch as well as develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants