Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Formater le code avec Prettier. #104

Closed
wants to merge 2 commits into from

Conversation

octo-topi
Copy link
Contributor

@octo-topi octo-topi commented Oct 21, 2021

🦄 Problème

Voir 1024pix/pix#3538

🤖 Solution

1024pix/pix#3538

Lors de l'application de lint:fix, je passe de 423 erreurs à 183 🤔 de type comma-dangle (règle mise à jour dans la version de eslint)

J'ai pourtant appliqué les mêmes changements que sur API, il n'y a que la version de eslint qui diffère.

Est-ce dû à eslint-plugin-prettier ? Il y a une issue

🌈 Remarques

Cette PR est dédicacée au linterman @sbedeau ; on continue ton travail !

Montée de version de eslint (breaking changes)

💯 Pour tester

Vérifier que la CI passe.
Introduire une erreur, vérifier que npm run lint renvoie <> 0

@octo-topi octo-topi added cross-team Toutes les équipes de dev work-in-progess When you need a review app to check it's working labels Oct 21, 2021
@octo-topi octo-topi self-assigned this Oct 21, 2021
@octo-topi octo-topi closed this Oct 10, 2022
@francois2metz francois2metz deleted the tech-format-code-prettier branch February 22, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev work-in-progess When you need a review app to check it's working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant