[TECH] Migration vers embroider #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr124.osc-fr1.scalingo.io |
nlepage
force-pushed
the
tech-embroider
branch
2 times, most recently
from
366189e
to
7987504
Compare
|
oh le mec |
nlepage
force-pushed
the
tech-embroider
branch
3 times, most recently
from
2b8e0f9
to
7f7be36
Compare
francois2metz
approved these changes
Jul 24, 2023
Downgrades ember-cookies to 0.5 and fixes build error due to ember-cookies 1.0
Allows to get rid of ember-inflector v3
Fixes ember-tui-editor forcing ember-auto-import's babel plugin activation and causing ReferenceError on emberAutoImportDynamic
Allows to get rid of ember-get-config v0 and hence get rid of babel 6, removing warning during build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Embroider est le nouveau système de build de Ember, mais PixEditor utilise encore l'ancien système de build.
🤖 Solution
Passer PixEditor sur Embroider.
🌈 Remarques
La police de l'application n'est plus la même, explication :
L'application utilise une bibliothèque CSS appelée Semantic UI.
Avant la mise en place de embroider, l'import des fonts Google était accidentellement supprimé du code CSS de Semantic UI lors de la minification.
Avec la mise en place de embroider, l'import des fonts Google est maintenant conservé, d'où le changement.
ember-cookies v1.0.0 pose problème lors du build, donc on downgrade ember-simple-auth de v6 en v5, afin de downgrade ember-cookies en v0.5.
ember-inflector v3 pose problème, donc on upgrade ember-cli-mirage de 2.0.1 à 2.4.0 afin de ne plus avoir que du ember-inflector v4.
ember-tui-editor force l'activation du plugin babel de ember-auto-import, qui devrait pouvoir être désactivé par embroider, upgrade de ember-tui-editor en v3.0.10 pour corriger ça.
Mise à jour de ember-cli-mirage en v3.0.0-alpha.3, permet de se débarasser de ember-get-config v0, et donc de babel v6, et supprime ainsi les derniers warning apparaissant durant le build.
Suppression de dépendances inutilisées/inutiles :
💯 Pour tester
Faire de la non régression dans toute l'application.