New feature selectedBorderColor param, border color changes if selectedBord… #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2017 11:44
…erColor is not null when onRegionSelect and onRegionDeselect occur
xoxefdp
changed the title
Even if zoom disabled, touch devices can still zoom the map if it's draggable.
* Added croatia * Added example page of croatia.
* US Congressional Districts based on census data (Equirectangular) * New map based on Wikimedia SVG. * Use ids as keys in JSON. * Improve ids and names.
…it leads to zoom in function not working after reset function executed. (#308)
* Add map of USA counties. * Add election colors example. * Rename election source and minify by using 3-char hex colors. * Update title. * Add map of USA counties. * Add election colors example. * Rename election source and minify by using 3-char hex colors. * Update title.
|
Updated PR history to make no conflict with actual project status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erColor is not null when onRegionSelect and onRegionDeselect occur
What does this PR do ?
adds a parameter that enables region border to change when onRegionSelect or onRegionDeselect occurs if parameter not null
How should this be tested ?
adding selectedBorderColor: #color / rgba( color, opacity ) to jqvmap selector object, check border color changes when region selects and deselects
What are the relevant issues ?
type_response_here
This Pull Request includes:
npm testnpm testnpm testWhat gif best describes how you feel about this work ?