REALMC-12640: Leverage app meta file when present to query admin api #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makesitgo
commented
Apr 22, 2022
| } | ||
|
|
||
| if i.App == "" { | ||
| var appOption string | ||
|
|
||
| if app.RootDir != "" { | ||
| i.AppMeta = app.Meta |
There was a problem hiding this comment.
// set AppMeta when --app flag is not provided and FindApp locates an app directory
makesitgo
commented
Apr 22, 2022
| }, | ||
| }, | ||
| { | ||
| description: "when inside a project directory should prompt for app when not flagged and provide client app id as a default", | ||
| description: "when inside a project directory should not prompt for app when not flagged and use client app id as the option", |
There was a problem hiding this comment.
these two tests were falsely passing... tc.procedure was never being invoked, "defaults" were set from app config files
makesitgo
commented
Apr 22, 2022
jandersongo
approved these changes
Apr 22, 2022
christineschen
approved these changes
Apr 22, 2022
|
|
||
| var findAppCalls int | ||
| realmClient.FindAppFn = func(groupID, appID string) (realm.App, error) { | ||
| findAppCalls++ |
There was a problem hiding this comment.
[q] why use an int here instead of a bool?
There was a problem hiding this comment.
it's actually testing that we only call it once rather than twice, so consider this like a "super bool" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.