REALMC-12577: Add Data API Config support to the CLI #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the import support PR in, these tests should pass on evergreen now, so I'm opening this up for review |
caiyingshen
approved these changes
May 19, 2022
| @@ -34,6 +34,7 @@ type AppStructureV2 struct { | |||
| Sync SyncStructure `json:"sync,omitempty"` | |||
| Secrets SecretsStructure `json:"secrets,omitempty"` | |||
| LogForwarders []map[string]interface{} `json:"log_forwarders,omitempty"` | |||
| DataAPIConfig map[string]interface{} `json:"data_api_config,omitempty"` | |||
There was a problem hiding this comment.
[q] as a more general question, when do we need to create a struct and when can we just use map[string]interface{}?
There was a problem hiding this comment.
the honest answer is "I don't know" 😅 but from looking around, it seems like we use structs for entities with more complicated file nesting. As an example, all of the info contained in a data source is spread between two directories and up to 4 different files, so in that case, it makes sense to be able to organize everything in a struct. For the Data API Config, all of the info is in just one JSON file, so using a map felt fine enough
malexandert
requested review from
christineschen
and removed request for
jandersongo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.mongodb.org/browse/REALMC-12577
This depends on https://github.com/10gen/baas/pull/6496 to be merged before tests will passThis has been merged