Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #51: Read content from markdown file #58

Closed
wants to merge 1 commit into from

Conversation

giatuongtran9
Copy link

_Can only ready from README.md
_I suggest to move those method to Main.js because we only need to show content of the file whenever the users click to that subject. Here, we show all content of all subjects after the page is loaded. This might caught problem later if the amount of .md file get bigger.
_My suggest is to use ComponentWillReceiveProps to load the only subject that users click. For exmaple: when the user click a specific subject, fetch function will get that subject name and attempt to load that only subject

@giatuongtran9 giatuongtran9 changed the title Read content from markdown file Add #51: Read content from markdown file Oct 29, 2019
@10-seconds
Copy link
Collaborator

We have improved the website. So can you re raised the PR. Sorry for incovience.

@10-seconds 10-seconds closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants