Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File names with @ not escaped #13

Closed
Stiofan opened this issue Oct 30, 2019 · 3 comments
Closed

File names with @ not escaped #13

Stiofan opened this issue Oct 30, 2019 · 3 comments
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@Stiofan
Copy link

Stiofan commented Oct 30, 2019

Describe the bug
➤ Preparing files...
svn: E200009: 'trunk/public/assets/images/chosen-sprite@2x.png': a peg revision is not allowed here
##[error]Docker run failed with exit code 123

File names with @ sign need to be escaped with double @@

@Stiofan Stiofan added the type:bug Something isn't working. label Oct 30, 2019
@helen
Copy link
Collaborator

helen commented Nov 15, 2019

We could do something like appending an @ to the end of every file name during add, it doesn't hurt anything.

@Stiofan Are you interested in working on a pull request?

@dinhtungdu
Copy link
Collaborator

I can't reproduce the issue. I tested with files with @ in the filename at the root directory and subdirectory, no error.

You can check the result here: https://github.com/dinhtungdu/command-palette/commit/5cf234b5900a54af56d7d8db7e71fc7979bf4688/checks?check_suite_id=344928829

I forked this repo and remove the svn commit part for testing.

@Gaya
Copy link
Contributor

Gaya commented Jan 6, 2020

Think I solved it in #22. Seems like paths to be removed were not escaped.

@jeffpaul jeffpaul added this to the 1.5.0 milestone Jan 17, 2020
@helen helen closed this as completed in cc8f3f1 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

5 participants