Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version is not updated when running Github Action #65

Closed
dalenguyen opened this issue Jan 31, 2021 · 4 comments
Closed

Version is not updated when running Github Action #65

dalenguyen opened this issue Jan 31, 2021 · 4 comments
Assignees
Labels
needs:feedback This requires reporter feedback to better understand the request. type:question Further information is requested.

Comments

@dalenguyen
Copy link

dalenguyen commented Jan 31, 2021

Describe the bug

When running Github Action, it keeps getting my old version of the plugin which returns an error when deploying to WordPress Plugin Directory

Steps to Reproduce

This is the failed actions: https://github.com/dalenguyen/firebase-wordpress-plugin/runs/1801687516?check_suite_focus=true

I tried with a different version of the tag, but it keeps the old one.

image

When running, it retrieves the old version:

image

Expected behavior

Github Actions passed

Additional context

@dalenguyen dalenguyen added the type:bug Something isn't working. label Jan 31, 2021
@jeffpaul
Copy link
Member

jeffpaul commented Feb 1, 2021

@dalenguyen the action is likely stripping the preceding v from v0.8.0, so you'll need to try 0.8.1 or something similar to see things work as expected.

@jeffpaul
Copy link
Member

jeffpaul commented Feb 1, 2021

Also note that the VERSION variable is really only recommended for testing purposes:

VERSION - defaults to the tag name; do not recommend setting this except for testing purposes.

@jeffpaul jeffpaul self-assigned this Feb 1, 2021
@jeffpaul jeffpaul added type:question Further information is requested. needs:feedback This requires reporter feedback to better understand the request. and removed type:bug Something isn't working. labels Feb 1, 2021
@jeffpaul
Copy link
Member

jeffpaul commented Feb 9, 2021

@dalenguyen is there anything else we can help you with on this or can we close the issue?

@dalenguyen
Copy link
Author

Yes, I can close it. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires reporter feedback to better understand the request. type:question Further information is requested.
Projects
None yet
Development

No branches or pull requests

2 participants