Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No zip attached to the release #67

Closed
vyskoczilova opened this issue Apr 5, 2021 · 4 comments
Closed

No zip attached to the release #67

vyskoczilova opened this issue Apr 5, 2021 · 4 comments
Assignees
Labels
needs:feedback This requires reporter feedback to better understand the request. type:question Further information is requested.
Milestone

Comments

@vyskoczilova
Copy link

Describe the bug

Deployed with action with "generate-zip" parameter, however, ended with "not found" issue:
image used this workflow. Maybe related to SLUG used?

Expected behavior

Attach zip to the release - https://github.com/vyskoczilova/kybernaut-ic-dic/releases/tag/1.6.4

@vyskoczilova vyskoczilova added the type:bug Something isn't working. label Apr 5, 2021
@vyskoczilova vyskoczilova changed the title No zip created No zip attached to the release Apr 5, 2021
@jeffpaul
Copy link
Member

@helen direct link to failed Upload release asset is here: https://github.com/vyskoczilova/kybernaut-ic-dic/runs/2272301755?check_suite_focus=true. Given that the GH repo is kybernaut-ic-dic but the SVN repo and SLUG environment variable is set to woolab-ic-dic, I wonder if that's the cause of failure here as @vyskoczilova hints at or something else?

@dinhtungdu
Copy link
Contributor

Hi @vyskoczilova, because you're using a custom slug, you need to use that slug in the upload release assets part

        SLUG: woolab-ic-dic
    - name: Upload release asset
      uses: actions/upload-release-asset@v1
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      with:
        upload_url: ${{ github.event.release.upload_url }}
        asset_path: ${{github.workspace}}/woolab-ic-dic.zip
        asset_name: woolab-ic-dic.zip
        asset_content_type: application/zip

@dinhtungdu dinhtungdu added type:question Further information is requested. needs:feedback This requires reporter feedback to better understand the request. and removed type:bug Something isn't working. labels Apr 24, 2021
@vyskoczilova
Copy link
Author

@dinhtungdu yeah, that makes sense. I'm pretty new with GitHub actions and haven't noticed that it works with different actions than the previous one so the slug is not passed.

@dinhtungdu
Copy link
Contributor

Closing this for now. Feel free to reopen/comment if need.

@helen helen added this to the 2.0.0 milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires reporter feedback to better understand the request. type:question Further information is requested.
Projects
None yet
Development

No branches or pull requests

4 participants