Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to view all post types when Pulling from an External Connection #861

Open
1 task done
dkotter opened this issue Mar 8, 2022 · 5 comments · May be fixed by #1002 or #1003
Open
1 task done

Add ability to view all post types when Pulling from an External Connection #861

dkotter opened this issue Mar 8, 2022 · 5 comments · May be fixed by #1002 or #1003
Assignees
@ankitrox
Labels
help wanted nice-to-have type:enhancement New feature or request.
Milestone
2.1.0

Comments

@dkotter
Copy link
Collaborator

dkotter commented Mar 8, 2022 •
edited

Is your enhancement related to a problem? Please describe.

When you go to the Pull screen for an Internal/Network Connection, we default to showing content from all supported post types. You can then filter down to just the post type you want (like Posts).

But for External Connections, we default to showing just Posts and there isn't a way to view content across all post types. This is because historically we were requesting content from a post type specific endpoint, so it was impossible to get content across multiple post types. But with the changes introduced in #811, we can now show content from across all supported post types, mirroring how we do this for Internal Connections.

One thing to note here is if you are on an External Connection that has had no content pulled or skipped yet, we utilize the old approach to grabbing content, from a post type specific endpoint and not the new endpoint introduced in #811. So that will need to be addressed here to fully support his new feature.

Screen Shot 2022-03-08 at 4 17 06 PM

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:enhancement New feature or request. label Mar 8, 2022
@jeffpaul jeffpaul added this to the 1.7.0 milestone May 4, 2022
@chigozieorunta chigozieorunta self-assigned this May 4, 2022
@jeffpaul
Copy link
Member

Noting that https://github.com/10up/distributor/tree/feature/861 may be a good start on this, so we'll want to credit @chigozieorunta once this issue gets resolved.

@peterwilsoncc
Copy link
Collaborator

As work in beginning on Distributor 2.0.0, I've moved this enhancement off the 1.7.0 milestone to allow the point release to focus on bug fixes.

@peterwilsoncc peterwilsoncc modified the milestones: 1.7.0, 2.0.0 Jul 11, 2022
@mehul0810 mehul0810 linked a pull request Jan 12, 2023 that will close this issue
Open
4 tasks
@ankitrox ankitrox linked a pull request Jan 12, 2023 that will close this issue
Open
4 tasks
@mehul0810
Copy link

@jeffpaul I have worked on this with the branch https://github.com/10up/distributor/tree/feature/861, tested the functionality and created a PR which is ready for review.

@ankitrox
Copy link

@mehul0810 This PR is also there, please check if there's something you can spot or helpful.

@peterwilsoncc peterwilsoncc modified the milestones: 2.0.0, 2.0.1 May 24, 2023
@peterwilsoncc
Copy link
Collaborator

I've moved this to 2.0.1 as the REST API endpoint this relies on will be getting modified in 2.0.0.

@peterwilsoncc peterwilsoncc modified the milestones: 2.0.1, 2.1.0 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitrox ankitrox

Labels
help wanted nice-to-have type:enhancement New feature or request.
Projects
Open Source Practice
Status: In Progress
Milestone
2.1.0
6 participants
@peterwilsoncc @dkotter @ankitrox @mehul0810 @jeffpaul @chigozieorunta