Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node and NPM versions #114

Closed
1 task done
Sidsector9 opened this issue Mar 30, 2023 · 3 comments · Fixed by #154
Closed
1 task done

Update node and NPM versions #114

Sidsector9 opened this issue Mar 30, 2023 · 3 comments · Fixed by #154
Assignees
@dhanendran
Labels
help wanted type:enhancement New feature or request.
Milestone
1.3.0

Comments

@Sidsector9
Copy link
Member

Sidsector9 commented Mar 30, 2023 •
edited
Loading

Is your enhancement related to a problem? Please describe.

@10up/eslint-config couldn't be updated as it couldn't satisfy the node and NPM requirements.

Adding to it, after upgrading node to 16, stylelint fails during installation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Sidsector9 Sidsector9 added the type:enhancement New feature or request. label Mar 30, 2023
@jeffpaul jeffpaul added this to the Future Release milestone Apr 3, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 1.1.0 Apr 10, 2023
@dkotter dkotter modified the milestones: 1.1.0, 1.2.0 Jun 16, 2023
@cameronterry cameronterry mentioned this issue Jul 14, 2023
Merged
4 tasks
This was referenced Jul 28, 2023
Closed
Closed
@kmgalanakis kmgalanakis self-assigned this Aug 11, 2023
@kmgalanakis
Copy link
Contributor

In this commit we updated the build process for the plugin . The @10up/eslint-config and the stylelint packages are no longer used.

The only thing that we could do in the context of this ticket is to update the minimum node version for this plugin to 16.0.0.

What do you think @jeffpaul?

@jeffpaul
Copy link
Member

@kmgalanakis seems like we can bump node and remove those two packages? (cc: @Sidsector9 )

@Sidsector9
Copy link
Member Author

@kmgalanakis agreed, I think we updating the following would do:

insecure-content-warning/package.json

Line 48 in 4052423

"node": ">=12.0.0"

@dkotter dkotter modified the milestones: 1.2.0, 1.3.0 Oct 16, 2023
@dhanendran dhanendran mentioned this issue Nov 24, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhanendran dhanendran

Labels
help wanted type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Update node version to 16 10up/insecure-content-warning
5 participants
@dkotter @kmgalanakis @jeffpaul @dhanendran @Sidsector9