Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast $title variable never assigned to $output #235

Closed
martinburch opened this issue May 3, 2023 · 0 comments · Fixed by #279
Closed

Podcast $title variable never assigned to $output #235

martinburch opened this issue May 3, 2023 · 0 comments · Fixed by #279
Assignees
Labels
help wanted Extra attention is needed type:question Further information is requested.
Milestone

Comments

@martinburch
Copy link

martinburch commented May 3, 2023

Shouldn't there be a line in the if to assign $title to the output?

Without this assignment, somehow the channel title is set elsewhere, and the only real way to notice this is to see that » has been changed to another separator character, –.

https://github.com/10up/simple-podcasting/blob/develop/includes/customize-feed.php#L44-L51

	if ( empty( $title ) ) {
		$title = get_bloginfo( 'name' );
		$title = "$title » {$term->name}";
	} else {
		$output = $title;
	}

	return $output;

I'm not sure what's going on here. What's the right way to set the channel title, first of all, and not have the title default to Podcast Title - Blog Title?

To fix this, I have edited my customize-feed.php to

	if ( empty( $title ) ) {
		// $title = get_bloginfo( 'name' );
		// $title = "$title » {$term->name}";
		$title = "{$term->name}";
		$output = $title;
	} else {

which is what I want for my single-podcast site.

@vikrampm1 vikrampm1 added the type:question Further information is requested. label May 4, 2023
@jeffpaul jeffpaul added this to the 1.7.0 milestone Jan 11, 2024
@dkotter dkotter modified the milestones: 1.7.0, 1.8.0 Jan 11, 2024
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Feb 12, 2024
@psorensen psorensen self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:question Further information is requested.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants