Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode file name support #59

Closed
radeno opened this issue Apr 24, 2018 · 1 comment
Closed

Unicode file name support #59

radeno opened this issue Apr 24, 2018 · 1 comment
Labels
type:bug Something isn’t working.

Comments

@radeno
Copy link
Contributor

radeno commented Apr 24, 2018

Hello,

based on this issue opened on WP support forum https://wordpress.org/support/topic/non-encoded-urls/ plugin can't handle properly with paths / filenames / directories with unicode characters.

Tested on slovak characters. Adding php function urlencode helps.
I don't open any PR, because I can't say if exists any other code parts, where url encoding is required.

This document https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#resource-names says, in Important block, that all names with certain characters should be percent-encoded. Don't know what certain characters are, but urlencode helps.

Maybe there is better way how to fix it.

@allan23
Copy link
Contributor

allan23 commented May 2, 2018

This looks like it could be resolved via PR: #61

@allan23 allan23 added the type:bug Something isn’t working. label May 2, 2018
@allan23 allan23 closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn’t working.
Projects
None yet
Development

No branches or pull requests

2 participants