Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Consider adding menu classes (with defaults) as options in Responsive Navigation Component. #180

Open
JustinSainton opened this issue Dec 13, 2018 · 2 comments

Comments

@JustinSainton
Copy link

It's not uncommon for us to use custom navigation walkers to modify the structure or underlying output of a navigation menu to adhere to alternative FED methodologies (be it BEM, ITCSS, etc).

This sometimes results in navigation items not having the class names expected by the Responsive Navigation component. It would be trivial to add these class names to the options object (with the existing core classes as defaults to maintain backward compatibility).

Happy to provide a PR if there's a consensus that this would be a valuable addition. Thanks for considering it!

@samikeijonen
Copy link

It's not uncommon for us to use custom navigation walkers to modify the structure or underlying output of a navigation menu to adhere to alternative FED methodologies (be it BEM, ITCSS, etc)

Quick note on this one. I don't think we should use custom walker if we only change classes. Those can be changed using filters.

@JustinSainton
Copy link
Author

For sure! Regardless of how the classes are mutated, being able to target them properly with this component would be a huge help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants