Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure with BrainMonkey #26

Closed
ericmann opened this issue Mar 31, 2015 · 3 comments
Closed

Restructure with BrainMonkey #26

ericmann opened this issue Mar 31, 2015 · 3 comments

Comments

@ericmann
Copy link
Collaborator

No description provided.

@ericmann ericmann added this to the 1.0 milestone Mar 31, 2015
@johnpbloch
Copy link
Contributor

I started working on this over the weekend and ran into a bit of a blocker. BrainMonkey requires PHP 5.4 or higher. WP_Mock currently requires 5.3 or higher. I'm hesitant to bump the version requirement of WP_Mock since 5.3 still accounts for a very large number of WordPress installations (including a large number of sites on WP Engine).

At this point, as I see it, we're left with 3 options:

  1. Bump our own required PHP version
  2. Close this issue as wontfix
  3. Try to get BrainMonkey to refactor with 5.3 support

I'm really leaning towards 2. 3 sounds both unreasonable and unlikely. Thoughts?

@johnpbloch
Copy link
Contributor

This change is even harder to justify when one considers that individual projects can still use BrainMonkey together with WP Mock and opt to use BrainMonkey's (IMO) superior DSL for setting expectations on code. Since both libraries use Mockery, the validation, etc. should be the same.

@johnpbloch johnpbloch removed this from the 1.0 milestone Sep 18, 2015
@ericmann
Copy link
Collaborator Author

Was an interesting idea at the time. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants