expectActionAdded not counting as an assertion when running test

[mikeselander]

I might be a little confused here, but when I run \WP_Mock::expectActionAdded, I get an all OK from the test, but the expectActionAdded calls don't seem to count towards the assertion count. Am I doing something wrong or does that mean they're passing and they would return a PHP error if they weren't?

\WP_Mock::expectActionAdded( 'admin_bar_menu', array( $this->Site_Lockdown, 'page_lockdown_display' ), 500 );
\WP_Mock::expectActionAdded( 'admin_init', array( $this->Site_Lockdown, 'set_lockdown_option' ), 105 );
\WP_Mock::expectActionAdded( 'init', array( $this->Site_Lockdown, 'lockdown_this_thing' ), 105 );
\WP_Mock::expectActionAdded( 'init', array( $this->Site_Lockdown, 'lockdown_actions' ), 5 );
\WP_Mock::expectActionAdded( 'admin_init', array( $this->Site_Lockdown, 'lockdown_actions' ), 5 );

$this->Site_Lockdown->hooks();

[johnpbloch]

You're not doing anything wrong; setting up expectations in WP Mock don't have an impact on assertion counts because they're not really assertions. WP_Mock comes with some custom assertions to use, though, assuming you're using \WP_Mock\Tools\TestCase as the foundation of all your test classes.

$this->assertHooksAdded() // makes sure your expect*Added expectations were honored
$this->assertActionsCalled() // makes sure your expected do_action()s were run
$this->assertConditionsMet() // makes sure all WP Mock expectations have been met

So in your snippet above, I'd just tweak it to be:

\WP_Mock::expectActionAdded( 'admin_bar_menu', array( $this->Site_Lockdown, 'page_lockdown_display' ), 500 );
\WP_Mock::expectActionAdded( 'admin_init', array( $this->Site_Lockdown, 'set_lockdown_option' ), 105 );
\WP_Mock::expectActionAdded( 'init', array( $this->Site_Lockdown, 'lockdown_this_thing' ), 105 );
\WP_Mock::expectActionAdded( 'init', array( $this->Site_Lockdown, 'lockdown_actions' ), 5 );
\WP_Mock::expectActionAdded( 'admin_init', array( $this->Site_Lockdown, 'lockdown_actions' ), 5 );

$this->Site_Lockdown->hooks();

$this->assertHooksAdded();

(And again, this all assumes you're doing MyTestClassTests extends \WP_Mock\Tools\TestCase, not MyTestClassTests extends \PHPUnit_Framework_TestCase. Which you should be.)

[mikeselander]

Gotcha, that makes sense. Thank you!