Skip to content

Commit

Permalink
fix: Address Mypy issue which is causing CI to fail (apache#25494)
Browse files Browse the repository at this point in the history
  • Loading branch information
john-bodley committed Oct 2, 2023
1 parent 0d0a81c commit 36ed617
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/unit_tests/db_engine_specs/test_clickhouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
String,
TypeEngine,
)
from urllib3.connection import HTTPConnection
from urllib3.exceptions import NewConnectionError

from superset.utils.core import GenericDataType
from tests.unit_tests.db_engine_specs.utils import (
Expand All @@ -56,14 +58,12 @@ def test_convert_dttm(


def test_execute_connection_error() -> None:
from urllib3.exceptions import NewConnectionError

from superset.db_engine_specs.clickhouse import ClickHouseEngineSpec
from superset.db_engine_specs.exceptions import SupersetDBAPIDatabaseError

cursor = Mock()
cursor.execute.side_effect = NewConnectionError(
"Dummypool", "Exception with sensitive data"
HTTPConnection("localhost"), "Exception with sensitive data"
)
with pytest.raises(SupersetDBAPIDatabaseError) as ex:
ClickHouseEngineSpec.execute(cursor, "SELECT col1 from table1")
Expand Down

0 comments on commit 36ed617

Please sign in to comment.