Skip to content

Commit

Permalink
fix: naming denomalized to denormalized in helpers.py (apache#25973)
Browse files Browse the repository at this point in the history
  • Loading branch information
hughhhh committed Nov 13, 2023
1 parent 99d4f89 commit 5def416
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions superset/models/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1343,11 +1343,11 @@ def get_time_filter( # pylint: disable=too-many-arguments
def values_for_column(self, column_name: str, limit: int = 10000) -> list[Any]:
# always denormalize column name before querying for values
db_dialect = self.database.get_dialect()
denomalized_col_name = self.database.db_engine_spec.denormalize_name(
denormalized_col_name = self.database.db_engine_spec.denormalize_name(
db_dialect, column_name
)
cols = {col.column_name: col for col in self.columns}
target_col = cols[denomalized_col_name]
target_col = cols[denormalized_col_name]
tp = self.get_template_processor()
tbl, cte = self.get_from_clause(tp)

Expand All @@ -1368,7 +1368,7 @@ def values_for_column(self, column_name: str, limit: int = 10000) -> list[Any]:
sql = self.mutate_query_from_config(sql)

df = pd.read_sql_query(sql=sql, con=engine)
return df[denomalized_col_name].to_list()
return df[denormalized_col_name].to_list()

def get_timestamp_expression(
self,
Expand Down

0 comments on commit 5def416

Please sign in to comment.