fix(import): Make sure query context is overwritten for overwriting i…

…mports (apache#25493)
10webio · Oct 16, 2023 · a0a0d80 · a0a0d80
1 parent 8c6bd4e
commit a0a0d80
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/superset/charts/commands/importers/v1/__init__.py b/superset/charts/commands/importers/v1/__init__.py
@@ -95,6 +95,6 @@ def _import(
                 config["params"].update({"datasource": dataset.uid})
 
                 if "query_context" in config:
-                    del config["query_context"]
+                    config["query_context"] = None
 
                 import_chart(session, config, overwrite=overwrite)
diff --git a/superset/commands/importers/v1/assets.py b/superset/commands/importers/v1/assets.py
@@ -117,7 +117,7 @@ def _import(session: Session, configs: dict[str, Any]) -> None:
                 dataset_uid = f"{dataset_dict['datasource_id']}__{dataset_dict['datasource_type']}"
                 config["params"].update({"datasource": dataset_uid})
                 if "query_context" in config:
-                    del config["query_context"]
+                    config["query_context"] = None
                 chart = import_chart(session, config, overwrite=True)
                 chart_ids[str(chart.uuid)] = chart.id
 

diff --git a/superset/dashboards/commands/importers/v1/__init__.py b/superset/dashboards/commands/importers/v1/__init__.py
@@ -118,7 +118,7 @@ def _import(
                 dataset_uid = f"{dataset_dict['datasource_id']}__{dataset_dict['datasource_type']}"
                 config["params"].update({"datasource": dataset_uid})
                 if "query_context" in config:
-                    del config["query_context"]
+                    config["query_context"] = None
 
                 chart = import_chart(session, config, overwrite=False)
                 chart_ids[str(chart.uuid)] = chart.id