forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(sqllab): ResultTable extension (apache#25423)
- Loading branch information
1 parent
150e5c9
commit deef3b0
Showing
10 changed files
with
470 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
superset-frontend/src/components/FilterableTable/useCellContentParser.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { renderHook } from '@testing-library/react-hooks'; | ||
| import { useCellContentParser } from './useCellContentParser'; | ||
|
|
||
| test('should return NULL for null cell data', () => { | ||
| const { result } = renderHook(() => | ||
| useCellContentParser({ columnKeys: [], expandedColumns: [] }), | ||
| ); | ||
| const parser = result.current; | ||
| expect(parser({ cellData: null, columnKey: '' })).toBe('NULL'); | ||
| }); | ||
|
|
||
| test('should return truncated string for complex columns', () => { | ||
| const { result } = renderHook(() => | ||
| useCellContentParser({ | ||
| columnKeys: ['a'], | ||
| expandedColumns: ['a.b'], | ||
| }), | ||
| ); | ||
| const parser = result.current; | ||
|
|
||
| expect( | ||
| parser({ | ||
| cellData: 'this is a very long string', | ||
| columnKey: 'a.b', | ||
| }), | ||
| ).toBe('this is a very long string'); | ||
| expect( | ||
| parser({ | ||
| cellData: '["this is a very long string"]', | ||
| columnKey: 'a', | ||
| }), | ||
| ).toBe('[…]'); | ||
| expect( | ||
| parser({ | ||
| cellData: '{ "b": "this is a very long string" }', | ||
| columnKey: 'a', | ||
| }), | ||
| ).toBe('{…}'); | ||
| }); |
69 changes: 69 additions & 0 deletions
69
superset-frontend/src/components/FilterableTable/useCellContentParser.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { useCallback, useMemo } from 'react'; | ||
|
|
||
| export type CellDataType = string | number | null; | ||
|
|
||
| export const NULL_STRING = 'NULL'; | ||
|
|
||
| type Params = { | ||
| columnKeys: string[]; | ||
| expandedColumns?: string[]; | ||
| }; | ||
|
|
||
| export function useCellContentParser({ columnKeys, expandedColumns }: Params) { | ||
| // columns that have complex type and were expanded into sub columns | ||
| const complexColumns = useMemo<Record<string, boolean>>( | ||
| () => | ||
| columnKeys.reduce( | ||
| (obj, key) => ({ | ||
| ...obj, | ||
| [key]: expandedColumns?.some(name => name.startsWith(`${key}.`)), | ||
| }), | ||
| {}, | ||
| ), | ||
| [expandedColumns, columnKeys], | ||
| ); | ||
|
|
||
| return useCallback( | ||
| ({ | ||
| cellData, | ||
| columnKey, | ||
| }: { | ||
| cellData: CellDataType; | ||
| columnKey: string; | ||
| }) => { | ||
| if (cellData === null) { | ||
| return NULL_STRING; | ||
| } | ||
| const content = String(cellData); | ||
| const firstCharacter = content.substring(0, 1); | ||
| let truncated; | ||
| if (firstCharacter === '[') { | ||
| truncated = '[…]'; | ||
| } else if (firstCharacter === '{') { | ||
| truncated = '{…}'; | ||
| } else { | ||
| truncated = ''; | ||
| } | ||
| return complexColumns[columnKey] ? truncated : content; | ||
| }, | ||
| [complexColumns], | ||
| ); | ||
| } |
Oops, something went wrong.