fix: Revert "fix(Charts): Set max row limit + removed the option to u…

…se an empty row limit value" (apache#25753)
10webio · Oct 25, 2023 · e2fe967 · e2fe967
1 parent 27a06f5
commit e2fe967
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 55 deletions.
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
@@ -47,8 +47,6 @@ import {
   isDefined,
   hasGenericChartAxes,
   NO_TIME_RANGE,
-  validateNonEmpty,
-  validateMaxValue,
 } from '@superset-ui/core';
 
 import {
@@ -245,12 +243,7 @@ const row_limit: SharedControlConfig<'SelectControl'> = {
   type: 'SelectControl',
   freeForm: true,
   label: t('Row limit'),
-  clearable: false,
-  validators: [
-    validateNonEmpty,
-    legacyValidateInteger,
-    v => validateMaxValue(v, 100000),
-  ],
+  validators: [legacyValidateInteger],
   default: 10000,
   choices: formatSelectOptions(ROW_LIMIT_OPTIONS),
   description: t(

diff --git a/superset-frontend/packages/superset-ui-core/src/validator/index.ts b/superset-frontend/packages/superset-ui-core/src/validator/index.ts
@@ -22,4 +22,3 @@ export { default as legacyValidateNumber } from './legacyValidateNumber';
 export { default as validateInteger } from './validateInteger';
 export { default as validateNumber } from './validateNumber';
 export { default as validateNonEmpty } from './validateNonEmpty';
-export { default as validateMaxValue } from './validateMaxValue';
diff --git a/superset-frontend/packages/superset-ui-core/src/validator/validateMaxValue.ts b/superset-frontend/packages/superset-ui-core/src/validator/validateMaxValue.ts
diff --git a/superset-frontend/packages/superset-ui-core/test/validator/validateMaxValue.test.ts b/superset-frontend/packages/superset-ui-core/test/validator/validateMaxValue.test.ts