Add sec-fetch-mode check #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips adding the live reload script to pages that are retrieved over fetch in browsers that support the Sec-Fetch-Mode header, which is useful for PJAX, custom elements that load their shadow templates asynchronously, or other static client-side apps.
|
Thank you! Shipping with v1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on some small tools and sites (such as https://github.com/Chalkbeat/powertoys/tree/main/tarot) where it's useful to have live reload built into a static server. However, I often retrieve HTML fragments over fetch (either to add dynamic content, or when writing custom elements that have non-trivial shadow root templates), and the current eleventy-dev-server appends the live reload script tag to these because it doesn't distinguish between page navigation and PJAX-like requests. This change adds a check for the
Sec-Fetch-Modeheader, and if it is present, only augments the HTML content if the header contains the "navigate" value, meaning that it's being loaded by the browser page navigation and not by client-side code.