Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows regression: test failure svgShortCircuit and generateHTML #122

Closed
zachleat opened this issue Aug 30, 2021 · 3 comments
Closed

Windows regression: test failure svgShortCircuit and generateHTML #122

zachleat opened this issue Aug 30, 2021 · 3 comments
Assignees
Labels
bug Something isn't working env: windows
Milestone

Comments

@zachleat
Copy link
Member

zachleat commented Aug 30, 2021

https://github.com/11ty/eleventy-img/runs/3457258328?check_suite_focus=true#step:5:20

image

test("svgShortCircuit and generateHTML: Issue #48", async t => {

markup » svgShortCircuit and generateHTML: Issue #48

  test\test-markup.js:179

   178:   });                                                                   
   179:   t.is(html, `<img alt="Tiger" src="/img/tZ4Kzy-sde-900.svg" width="900…
   180: });                                                                     

  Difference:

  - '<img alt="Tiger" src="/img/meihGYoHjb-900.svg" width="900" height="900">'
  + '<img alt="Tiger" src="/img/tZ4Kzy-sde-900.svg" width="900" height="900">'

  » test/test-markup.js:179:5
@zachleat zachleat added bug Something isn't working env: windows labels Aug 30, 2021
@zachleat
Copy link
Member Author

zachleat commented Aug 30, 2021

Regression after #116.

Looks like the hash might be somehow calculated differently for SVG content on windows.

@zachleat zachleat changed the title Regression: test failure svgShortCircuit and generateHTML Windows regression: test failure svgShortCircuit and generateHTML Aug 30, 2021
@zachleat
Copy link
Member Author

Note that this SVG test passes fine on Windows:

test("SVG files and dryRun: Issue #72", async t => {

zachleat added a commit that referenced this issue Aug 30, 2021
zachleat added a commit that referenced this issue Aug 30, 2021
@zachleat
Copy link
Member Author

Yay I fixed it

@zachleat zachleat self-assigned this Aug 30, 2021
@zachleat zachleat added this to the v1.0.0 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env: windows
Projects
None yet
Development

No branches or pull requests

1 participant