Adds ability to use absolute file paths on Windows. Fixes #137 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great PR—thank you! |
|
Side note: I think I will probably alias Util.isFullUrl to isRemoteUrl for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#137 explains the issues when using absolute file paths on Windows. With these changes, such usage is now possible.
I have also renamed
isFullUrltoisRemoteUrl. I thought the name was misleading because the intent and the name seem to be different: the intent is to find out whether the value of constructor parametersrc, passed to the method asurl, points to a remote resource or not, as evidenced by the return value being assigned to a property namedisRemoteUrl, but the method name suggests that this method indicates whether a URL is a "full" one (is there a half URL?). As this is not part of the public API of this package, however, it's less of a concern and I'm happy to revert that part if there is objection to the rename.