Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading base version of LiquidJS in 11ty standard package #1545

Closed
danfascia opened this issue Dec 7, 2020 · 7 comments
Closed

Comments

@danfascia
Copy link

I know that I can upgrade my LiquidJS node_module and import a new version of the Liquid rendering engine myself - which I do so that I can access some of the great features of the Liquid language (such as the where filter).

I'm wondering why the LiquidJS version included in 11ty is stuck back on version 6.4.3 and @zachleat would consider upgrading by default to the latest stable library version in the next 11ty version?

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 7, 2020

master is already on v9 (I see, a37a5c6 from September 2020 for example).

Will be released with v1, I guess.

@danfascia
Copy link
Author

Ohhh... then I have a glitch in the works! Must be a hardcoded version somewhere in a package which I need to change to @latest

Good to see this because Liquid seems to have the best filters as well as being faster than NJK on benchmarks

@zachleat
Copy link
Member

zachleat commented Dec 7, 2020

I believe this is a dupe of #469 and #1058, both on https://github.com/orgs/11ty/projects/5

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 8, 2020

Ah, those are the issue / PR I was looking for!

@danfascia
Copy link
Author

OK actually I'm back again because something really strange is going on.

From a completely fresh install where all that I do is npm install @11ty/eleventy the liquidjs module it pulls down is 6.4.3

Why is it reverting to this old outdated dependency version?

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Dec 8, 2020

Because v1 is not published yet. You can install from a branch instead: npm i @11ty/elventy#master should pull directly from the master branch (as long as it wasn't renamed to main).

Be aware, that it is bleeding edge!

@binyamin
Copy link
Member

You can also use npm i github:11ty/eleventy, without specifying the branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants