-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Liquid major version #469
Comments
Any reason for this not being in the v0.8.0 beta? I mis-read the release notes, and thought it had bumped Liquid to the latest major version, but was actually a minor one. I only ask as I came across an issue, and having certainty about the version used by 11ty (having tried to install the latest major version separately) would help me resolve it. |
The reason is that it would break compatibility if anyone is using the options keys that were renamed. See https://www.11ty.io/docs/languages/liquid/#optional%3A-use-your-own-options |
Hmm It’s possible we could shim those—I’ll have to think about it. |
@zachleat Investigating using my own instance of Liquid, thought it was worth recording the raw build times seen when swapping out the built in version for the latest release. With builtin LiquidJS instance (6.4.3), 5 runs:
Average build time: 15.86 seconds With own LiquidJS instance (9.6.2), 5 runs:
Average build time: 11.89 seconds (~25% faster) Seems like some sizeable performance gains to be had for Liquid-based sites! |
I will add that v6 is fairly incomplete compared to the official Liquid implementation, with several filters missing (that have since been added to liquidjs) such as |
As an FYI (and I know GitHub linked it already), I raised this issue at a high level here: #906. |
+1 to shimming "strict_filters" to "strictFilters" when bumping up to liquidjs v9 (so that both are supported and we don't break anything). |
Lack of |
🎉 |
I’ve updated the dependency again to the latest since the PR #1058 was a little old 👍🏻 |
We are on v6, they are on v8.
https://github.com/harttle/liquidjs/blob/master/CHANGELOG.md
Breaking changes apply to options name changes (no template facing changes here).
See also harttle/liquidjs#109
The text was updated successfully, but these errors were encountered: