Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin compatibility with prereleases #2001

Closed
zachleat opened this issue Oct 7, 2021 · 4 comments
Closed

Plugin compatibility with prereleases #2001

zachleat opened this issue Oct 7, 2021 · 4 comments
Labels
feature: 🔌 plugins Plugin API release: beta A release on the beta channel

Comments

@zachleat
Copy link
Member

zachleat commented Oct 7, 2021

Both canary and beta prerelease tags have trouble in the UserConfig->versionCheck method.

Normal version checking approach: https://github.com/11ty/eleventy-navigation/blob/fccb334e0d7cad363bda691178cb53e35ee79981/package.json#L35 and https://github.com/11ty/eleventy-navigation/blob/fccb334e0d7cad363bda691178cb53e35ee79981/.eleventy.js#L6

Related 11ty/eleventy-plugin-rss#28

We need to use the includePrerelease option to include these:

This will ship in 1.0.0-beta.2

@zachleat
Copy link
Member Author

zachleat commented Oct 7, 2021

For now existing plugins will need to keep the canary check in place to keep compatibility with the canary tag, as canary versions of Eleventy will not have this includePrelease option enabled.

"11ty": {
  "compatibility": ">=0.7 || >=1.0.0-canary"
},

Once folks are on the beta tag we can get rid of it moving forward (and of course we needn’t add a || >= 1.0.0-beta check either as this will be solved in 1.0.0-beta.2 core)

@zachleat
Copy link
Member Author

zachleat commented Oct 7, 2021

We’ll probably want to ship 1.0.0-beta.2 soon so that folks don’t run into this.

@zachleat
Copy link
Member Author

zachleat commented Oct 7, 2021

1.0.0-beta.2 has shipped.

@zachleat
Copy link
Member Author

zachleat commented Oct 7, 2021

Review of core plugin compatibility checks, need to remove peerDependencies entry and move instead to 11ty.compatibility method in package.json:

Not applicable, do not need peerDependencies: eleventy-img, eleventy-cache-assets

zachleat added a commit to 11ty/eleventy-plugin-rss that referenced this issue Oct 7, 2021
zachleat added a commit to 11ty/eleventy-plugin-inclusive-language that referenced this issue Oct 7, 2021
@zachleat zachleat added the feature: 🔌 plugins Plugin API label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: 🔌 plugins Plugin API release: beta A release on the beta channel
Projects
None yet
Development

No branches or pull requests

1 participant