Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer permission requests for Deno #3278

Closed
zachleat opened this issue May 5, 2024 · 2 comments
Closed

Fewer permission requests for Deno #3278

zachleat opened this issue May 5, 2024 · 2 comments
Labels
enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.

Comments

@zachleat
Copy link
Member

zachleat commented May 5, 2024

v2 and v3 seem to work fine with Deno, although our test runner ava does not so we can not yet run the full Eleventy test suite.

deno --allow-read --allow-write npm:@11ty/eleventy
deno --allow-read --allow-write npm:@11ty/eleventy@canary
deno --allow-read --allow-write npm:@11ty/eleventy@canary

Noting that --allow-write is only necessary when using --to=fs (not --dryrun).

These additional permissions are requested:

  • env access
  • node:os.cpus() via fs.walk and fast-glob

Can we reduce some of these?

@zachleat zachleat added the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Jun 19, 2024
@zachleat
Copy link
Member Author

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@zachleat
Copy link
Member Author

zachleat commented Jul 3, 2024

Once this work is complete we can add Deno to the package manager commands on the official docs alongside pnpm and yarn as noted here #2876 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.
Projects
None yet
Development

No branches or pull requests

1 participant