Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove htmlOutputSuffix Common Pitfall when input and output directories match. #3327

Closed
zachleat opened this issue Jun 18, 2024 · 1 comment
Closed

Remove htmlOutputSuffix Common Pitfall when input and output directories match. #3327

zachleat opened this issue Jun 18, 2024 · 1 comment
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. needs-documentation Documentation for this issue/feature is pending!
Milestone
Eleventy 3.0.0

Comments

@zachleat
Copy link
Member

zachleat commented Jun 18, 2024 •
edited
Loading

Read more about what happens when you use the same directory for input and output:
https://v2-0-1.11ty.dev/docs/languages/html/#using-the-same-input-and-output-directories

Read more about what the htmlOutputSuffix feature did:
https://v2-0-1.11ty.dev/docs/config/#change-exception-case-suffix-for-html-files

From a GitHub search this feature is almost never modified from default: https://github.com/search?q=htmlOutputSuffix&type=code&p=1

Double processing templates should simply throw an error. Removing this feature would result in duplicate permalink errors.

Run 1:
README.md -> README/index.html

Run2:
README.md -> README/index.html
README/index.html -> README/index.html (duplicate permalink error)
@zachleat zachleat added the breaking-change This will have to be included with a major version as it breaks backwards compatibility. label Jun 18, 2024
@zachleat zachleat added this to the Eleventy 3.0.0 milestone Jun 18, 2024
@zachleat
Copy link
Member Author

Alternatively:

./index.html -> ./index.html (should also error)

@zachleat zachleat added the needs-documentation Documentation for this issue/feature is pending! label Jun 18, 2024
@zachleat zachleat mentioned this issue Jun 27, 2024
Closed
zachleat added a commit to 11ty/eleventy-upgrade-help that referenced this issue Jul 23, 2024
@zachleat
Upgrade helper for 11ty/eleventy#3327
d583b70
@zachleat zachleat mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. needs-documentation Documentation for this issue/feature is pending!
Projects
None yet
Milestone
Eleventy 3.0.0
Development

No branches or pull requests
1 participant
@zachleat